feat(mqtt): MosquittoContainer: Add version 2.1.2#978
Open
f18m wants to merge 4 commits intotestcontainers:mainfrom
Open
feat(mqtt): MosquittoContainer: Add version 2.1.2#978f18m wants to merge 4 commits intotestcontainers:mainfrom
f18m wants to merge 4 commits intotestcontainers:mainfrom
Conversation
beb33d5 to
700d1a8
Compare
alexanderankin
requested changes
Mar 18, 2026
Member
alexanderankin
left a comment
There was a problem hiding this comment.
what is the goal here?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #978 +/- ##
==========================================
+ Coverage 78.71% 78.96% +0.24%
==========================================
Files 14 14
Lines 1217 1217
Branches 142 142
==========================================
+ Hits 958 961 +3
+ Misses 218 214 -4
- Partials 41 42 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
hey @alexanderankin , |
Member
|
ok lets make sure this doesnt cause weirdness with the hardcoded volume name. lets use a uuid or something there |
Member
|
if you can figure out how to mount tmpfs that would be even better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the testcontainer MosquittoContainer (which I contributed to this project a few years ago) to work with version 2.1.2 and higher of Mosquitto.
In particular this PR is fixing an issue where rw mode is now needed for /data partition for Mosquitto version 2.1.1 (released 2026-02-04), which fixed a PUID/PGID issue.
In addition, it contains a fix for Mosquitto warnings generated by the
listenerdirective appearing afterprotocoldirective.