Skip to content

feat(mqtt): MosquittoContainer: Add version 2.1.2#978

Open
f18m wants to merge 4 commits intotestcontainers:mainfrom
f18m:fix-mosquitto
Open

feat(mqtt): MosquittoContainer: Add version 2.1.2#978
f18m wants to merge 4 commits intotestcontainers:mainfrom
f18m:fix-mosquitto

Conversation

@f18m
Copy link
Contributor

@f18m f18m commented Mar 6, 2026

This PR enables the testcontainer MosquittoContainer (which I contributed to this project a few years ago) to work with version 2.1.2 and higher of Mosquitto.

In particular this PR is fixing an issue where rw mode is now needed for /data partition for Mosquitto version 2.1.1 (released 2026-02-04), which fixed a PUID/PGID issue.
In addition, it contains a fix for Mosquitto warnings generated by the listener directive appearing after protocol directive.

@alexanderankin alexanderankin changed the title MosquittoContainer: Add version 2.1.2 feat(mqtt): MosquittoContainer: Add version 2.1.2 Mar 18, 2026
Copy link
Member

@alexanderankin alexanderankin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the goal here?

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.96%. Comparing base (b12ae13) to head (700d1a8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
+ Coverage   78.71%   78.96%   +0.24%     
==========================================
  Files          14       14              
  Lines        1217     1217              
  Branches      142      142              
==========================================
+ Hits          958      961       +3     
+ Misses        218      214       -4     
- Partials       41       42       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@f18m
Copy link
Contributor Author

f18m commented Mar 18, 2026

hey @alexanderankin ,
sorry I forgot to update the description of the PR, doing now.

@f18m f18m marked this pull request as ready for review March 18, 2026 09:42
@alexanderankin
Copy link
Member

ok lets make sure this doesnt cause weirdness with the hardcoded volume name. lets use a uuid or something there

@alexanderankin
Copy link
Member

if you can figure out how to mount tmpfs that would be even better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants